Bump k8s modules to 0.24.0 #7073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #7073 +/- ##
=======================================
Coverage 44.09% 44.09%
=======================================
Files 46 46
Lines 1279 1279
Branches 179 179
=======================================
Hits 564 564
Misses 677 677
Partials 38 38 |
|
@shu-mutou Can we avoid regular bumps until #7047 will be merged? It will cause conflicts that we will need to resolve. If you want you can update the dependencies in the branch directly. |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm We will do release supporting new K8s version. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
floreks
pushed a commit
to maciaszczykm/kubernetes-dashboard
that referenced
this pull request
Aug 5, 2022
maciaszczykm
added a commit
that referenced
this pull request
Sep 16, 2022
* Start moving files * Move modules to the root dir * Fix backend import paths * Move some scripts * Add API workflow * Update codegen scripts * Update gitignores * Update API workflow * Update API workflow * Update backend structure * Update backend structure * Add modules dir * Update structure * Split frontend and update web build logic * Update license config * Add tools module * Add license check workflow * Fix licenses * Update scripts * Update workflows * Update workflows * Lower npm requirements to bundled version * Update package-lock.json * Update configs * Remove unused code * Add workspace support and update web handling * Bump github/codeql-action from 2.1.8 to 2.1.9 (#7049) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.8 to 2.1.9. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@1ed1437...7502d6e) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/node from 17.0.29 to 17.0.30 (#7059) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 17.0.29 to 17.0.30. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump core-js from 3.22.2 to 3.22.3 (#7055) Bumps [core-js](https://github.com/zloirock/core-js) from 3.22.2 to 3.22.3. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](zloirock/core-js@v3.22.2...v3.22.3) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/setup-buildx-action from 1.6.0 to 1.7.0 (#7056) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 1.6.0 to 1.7.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@94ab11c...f211e3e) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump typescript from 4.6.3 to 4.6.4 (#7060) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.6.3 to 4.6.4. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.6.3...v4.6.4) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ts-loader from 9.2.9 to 9.3.0 (#7062) Bumps [ts-loader](https://github.com/TypeStrong/ts-loader) from 9.2.9 to 9.3.0. - [Release notes](https://github.com/TypeStrong/ts-loader/releases) - [Changelog](https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md) - [Commits](TypeStrong/ts-loader@v9.2.9...v9.3.0) --- updated-dependencies: - dependency-name: ts-loader dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump stylelint from 14.8.0 to 14.8.1 (#7065) Bumps [stylelint](https://github.com/stylelint/stylelint) from 14.8.0 to 14.8.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@14.8.0...14.8.1) --- updated-dependencies: - dependency-name: stylelint dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/core from 7.17.9 to 7.17.10 (#7066) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.17.9 to 7.17.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.17.10/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/node from 17.0.30 to 17.0.31 (#7064) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 17.0.30 to 17.0.31. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/preset-env from 7.16.11 to 7.17.10 (#7063) Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.16.11 to 7.17.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.17.10/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: deploy `helm` with name `kubernetes-dashboard` (#7068) * docs: deploy `helm` with name `my-release` * docs: change all `my-release` to `kubernetes-dashboard` * Bump @typescript-eslint/eslint-plugin from 5.21.0 to 5.22.0 (#7070) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.21.0 to 5.22.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.22.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/jest from 27.4.1 to 27.5.0 (#7069) Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 27.4.1 to 27.5.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump core-js from 3.22.3 to 3.22.4 (#7071) Bumps [core-js](https://github.com/zloirock/core-js) from 3.22.3 to 3.22.4. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](zloirock/core-js@v3.22.3...v3.22.4) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update Japanese translation (Line 1-1593) (#7054) * Update Japanese translation (Line 1-1593) * Update i18n/ja/messages.ja.xlf * Update i18n/ja/messages.ja.xlf * Update i18n/ja/messages.ja.xlf * Update i18n/ja/messages.ja.xlf * Update i18n/ja/messages.ja.xlf * Update i18n/ja/messages.ja.xlf * Update i18n/ja/messages.ja.xlf * Update i18n/ja/messages.ja.xlf * Update i18n/ja/messages.ja.xlf * Update i18n/ja/messages.ja.xlf Co-authored-by: Shu Muto <shu.mutow@nec.com> * Bump @typescript-eslint/parser from 5.21.0 to 5.22.0 (#7072) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.21.0 to 5.22.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.22.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/setup-qemu-action from 1.2.0 to 2 (#7074) Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 1.2.0 to 2. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@27d0a4f...8b12248) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/setup-buildx-action from 1.7.0 to 2 (#7075) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 1.7.0 to 2. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@f211e3e...dc7b971) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support for IngressClass [#5232] (#6920) * Update Japanese translation(Line 1594-2887) (#7079) * Update Japanese translation(Line 1594-2887) * modified Japanese translation(Line 1594-2887) * Update i18n/ja/messages.ja.xlf Co-authored-by: atoato88 <akihito-inou@nec.com> Co-authored-by: atoato88 <akihito-inou@nec.com> * Comment targets to migrate * Add licence ignores * Refactor workflows * Other updates * Workflow updates * Workflow updates * Workflow updates * Workflow updates * Add Go lint action * Format files * Fix serve target and update build pipeline * go mod tidy for tools * Add ensure target for golangci-lint * Add ensure go target to tools * Use private targets in makefile * Optimize targets * Update i18n handling for web * Remove deprecated ngx-i18nsupport package and use ng-extract-i18n-merge instead * Fix package.json * Add nginx gateway and make targets to run prod version of the application locally * Bump github/codeql-action from 2.1.9 to 2.1.10 (#7095) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.9 to 2.1.10. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@7502d6e...75b4f1c) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix path * Update Japanese translation(Line 2888-5094) (#7096) * Update Japanese translation(Line 2888-5094) * modified Japanese translation(Line 2888-5094) * Update i18n/ja/messages.ja.xlf Co-authored-by: atoato88 <akihito-inou@nec.com> * Update i18n/ja/messages.ja.xlf Co-authored-by: atoato88 <akihito-inou@nec.com> * Update i18n/ja/messages.ja.xlf Co-authored-by: atoato88 <akihito-inou@nec.com> * Update i18n/ja/messages.ja.xlf Co-authored-by: atoato88 <akihito-inou@nec.com> * Update i18n/ja/messages.ja.xlf Co-authored-by: atoato88 <akihito-inou@nec.com> * Update i18n/ja/messages.ja.xlf Co-authored-by: atoato88 <akihito-inou@nec.com> * Update i18n/ja/messages.ja.xlf Co-authored-by: atoato88 <akihito-inou@nec.com> * Update i18n/ja/messages.ja.xlf Co-authored-by: atoato88 <akihito-inou@nec.com> * Update i18n/ja/messages.ja.xlf Co-authored-by: Shu Muto <shu.mutow@nec.com> * Update i18n/ja/messages.ja.xlf Co-authored-by: Shu Muto <shu.mutow@nec.com> * Update i18n/ja/messages.ja.xlf Co-authored-by: Shu Muto <shu.mutow@nec.com> Co-authored-by: atoato88 <akihito-inou@nec.com> Co-authored-by: Shu Muto <shu.mutow@nec.com> * Update messages.de.xlf (#7117) Fixed typo in german translation for community. #7113 * Bump angular staffs to 13.3.5 (#7053) cli and build-angular were still 13.3.4. * Bump k8s modules to 0.24.0 (#7073) * chore(deps): Included dependency review (#7102) > Dependency Review GitHub Action in your repository to enforce dependency > reviews on your pull requests. > The action scans for vulnerable versions of dependencies introduced by package version > changes in pull requests, > and warns you about the associated security vulnerabilities. > This gives you better visibility of what's changing in a pull request, > and helps prevent vulnerabilities being added to your repository. https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/about-dependency-review#dependency-review-enforcement Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com> * chore: Set permissions for GitHub actions (#7036) Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much. - Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs [Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/) Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Update docs for 1.24+ (#6967) * Bump actions/setup-go from 3.0.0 to 3.2.0 (#7131) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3.0.0 to 3.2.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@f6164bd...b22fbbc) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action (#7107) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 75b4f1c4669133dc294b06c2794e969efa2e5316 to 2.1.11. This release includes the previously tagged commit. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@75b4f1c...a3a6c12) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-node from 3.1.1 to 3.2.0 (#7106) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.1.1 to 3.2.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@56337c4...17f8bd9) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dependencies and prepare for v2.6.0 release (#7140) * Update dependencies * Update dependencies * Update dependabot config * Fix startup * Add dependabot config for Golang * Minor update * Fix unit tests Bump version * Bump metrics-server version * Fix static check * Update Goland dependencies * Revert app version in Helm chart * Update lockfile * Update dev pipeline * Update run pipeline * Cleanup the build and start adding the multi arch build targets for the release pipeline * add serviceMonitor labels/annotations (#7120) * add serviceMonitor labels/annotations * Update aio/deploy/helm-chart/kubernetes-dashboard/Chart.yaml Co-authored-by: Cédric de Saint Martin <cdesaintmartin@wiremind.io> Co-authored-by: Cédric de Saint Martin <cdesaintmartin@wiremind.io> * Update Helm chart (#7167) * Updates after merge * Set correct working dir * Set correct working dir * Update API tests * Fix file path * Add cache * Pipeline improvements * Workflow and test updates * Rewrite client-gen support and update improve multiarch build * Remove leftover i18n from root dir * Update web scripts * Update workflows * Update API workflow * Fix dependencies * Restore overrides * Update dev pipeline * Cleanup * Refactor partial makefiles and web frontend build * Fix top level build * Update dashboard-arguments.md * fix: close sizeChan to avoid memory leak. (#7244) * Use batch/v1 API & Add /health endpoint & Fix CronJob OwnerRef (#7301) * Use batch/v1 instead of batch/v1beta1, add OwnerReference to Job when triggering CronJob, add simple /health endpoint * Add license * Fix test and run go mod tidy * Update go.mod * Update dashboard-arguments.md * fix: fix panic while RsaKeyHolder secret is nil (#7189) * fix: fix panic while RsaKeyHolder secret is nil * test: add test for auth.NewBasicAuthenticator * go mod tidy and fix master merge issues * go mod tidy and fix master merge issues * Remove unused files * Fix build/serve pipeline * Update codecov config * Bump Go version * Set GOPATH * Retry * Retry * Retry * Fix variable name * Update API workflow * Bump golangci-lint * Update web workflow * Fix path * Remove some of npm occurences * Bump Go dependencies Remove deprecated linters goimport files * Goimport rest of the files * Update web workflow * Fix license check * Remove duplicated deps review action and tidy dependencies to solve critical security issue * Fix web static check and remove unused conf variables * Bump dependency review action * Workflow cleanup * Remove ng-in-viewport to fix tests * Revert "Remove ng-in-viewport to fix tests" This reverts commit 279e649. * Fix typo * Fix typo * Remove duplicated import * Optimize web dependencies, improve prod run * Add ngcc postinstall command to yarn * Fix license check * Fix web static check * Update test config * Remove code freeze warning * Update codecov config * Update coverage config * Bump coverage action version * Retry * Export GOPATH in e2e * Use yarn to run e2e * Add missing script * Update e2e setup * Fix wait-on script * Fix e2e config * Merge new translations from master * Retry with different port number * Retry * Send serve process to background * Add missing vars * Fix typo * Retry * Update translation * Fix translation file Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com> Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> Co-authored-by: Sebastian Florek <s.florek91@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JounQin <admin@1stg.me> Co-authored-by: ziyi-xie <92832323+ziyi-xie@users.noreply.github.com> Co-authored-by: Shu Muto <shu.mutow@nec.com> Co-authored-by: Andrea Decorte <adecorte@gmail.com> Co-authored-by: atoato88 <akihito-inou@nec.com> Co-authored-by: David Roth <david.roth@fusonic.net> Co-authored-by: Naveen <172697+naveensrinivasan@users.noreply.github.com> Co-authored-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> Co-authored-by: Jordan Liggitt <liggitt@google.com> Co-authored-by: TheRealNoob <TheRealNoob@users.noreply.github.com> Co-authored-by: Cédric de Saint Martin <cdesaintmartin@wiremind.io> Co-authored-by: 意琦行 <31980412+lixd@users.noreply.github.com> Co-authored-by: L. Jiang <l.jiang.1024@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.